Downgrade error to beta-warning for gs selection in AxClient #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59143308 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 483 483
Lines 47246 47247 +1
=======================================
+ Hits 44988 44989 +1
Misses 2258 2258 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D59143308 |
mgarrard
force-pushed
the
export-D59143308
branch
from
cf2f195
to
f47a2f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59143308 |
mgarrard
force-pushed
the
export-D59143308
branch
from
f47a2f6
to
a13749a
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jul 1, 2024
…k#2551) Summary: Pull Request resolved: facebook#2551 Previously we added this error in D56048665 in response to a github issue, however now that we are adding support for GenerationStrategy selection for BatchTrials this can be a warning that this method is in development. In the future we should be able to fully remove the method Reviewed By: Balandat Differential Revision: D59143308
…k#2551) Summary: Pull Request resolved: facebook#2551 Previously we added this error in D56048665 in response to a github issue, however now that we are adding support for GenerationStrategy selection for BatchTrials this can be a warning that this method is in development. In the future we should be able to fully remove the method Reviewed By: Balandat Differential Revision: D59143308
|
This pull request was exported from Phabricator. Differential Revision: D59143308 |
mgarrard
force-pushed
the
export-D59143308
branch
from
a13749a
to
0da16d2
Compare
|
This pull request has been merged in d6ed7a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we added this error in D56048665 in response to a github issue, however now that we are adding support for GenerationStrategy selection for BatchTrials this can be a warning that this method is in development.
In the future we should be able to fully remove the method
Differential Revision: D59143308