Fix incorrect status quo update warning #2586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is something Ben brought up as something to improve a couple months ago. Right now, with almost everything we do in any of the clients there is a warning about status quo being updated, even though it is often not being updated. It turns out this is because of the incorrect positioning of the warning in the status quo setter. In this diff I 1) move the logger warning to be under the self._status_quo is None check 2) added a unit test modification Differential Revision: D59894197
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59894197 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 489 489
Lines 47642 47645 +3
=======================================
+ Hits 45369 45372 +3
Misses 2273 2273 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 9679f7b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is something Ben brought up as something to improve a couple months ago. Right now, with almost everything we do in any of the clients there is a warning about status quo being updated, even though it is often not being updated. It turns out this is because of the incorrect positioning of the warning in the status quo setter.
In this diff I
Differential Revision: D59894197