AnalysisCard refactor #2589
Closed
AnalysisCard refactor #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59926999 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
==========================================
- Coverage 95.21% 95.19% -0.02%
==========================================
Files 489 495 +6
Lines 47678 47750 +72
==========================================
+ Hits 45396 45457 +61
- Misses 2282 2293 +11 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D59926999 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jul 19, 2024
Summary: Pull Request resolved: facebook#2589 New structure for Analysis to make the Ax classes easier to reason about in light of storage considerations. The central change is to break up the existing Analysis class into **Analysis** (code for "how" a plot is to be generated) and **AnalysisCard** (the generated plot and its raw data). See N5607609 for demo. ## Analysis * Init method to take in "settings" (like which parameter or metrics to operate on, or whether to use observed or modeled effects) and store on class * compute method takes in Experiment or GenerationStrategy (or both) and outputs an AnalysisCard * Analysis is a Protocol to allow users to easily implement their own analyses structurally ## AnalysisCard * Contains the raw data computed by the analysis and a "blob" which holds data processed and ready for end-user consumption (ex. a plot) * Contains other miscellaneous metadata that can be useful for rendering the card or a collection of cards See the following diff for sample usage. Differential Revision: D59926999
mpolson64
force-pushed
the
export-D59926999
branch
from
2c459ba
to
d6469f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59926999 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jul 19, 2024
Summary: Pull Request resolved: facebook#2589 New structure for Analysis to make the Ax classes easier to reason about in light of storage considerations. The central change is to break up the existing Analysis class into **Analysis** (code for "how" a plot is to be generated) and **AnalysisCard** (the generated plot and its raw data). See N5607609 for demo. ## Analysis * Init method to take in "settings" (like which parameter or metrics to operate on, or whether to use observed or modeled effects) and store on class * compute method takes in Experiment or GenerationStrategy (or both) and outputs an AnalysisCard * Analysis is a Protocol to allow users to easily implement their own analyses structurally ## AnalysisCard * Contains the raw data computed by the analysis and a "blob" which holds data processed and ready for end-user consumption (ex. a plot) * Contains other miscellaneous metadata that can be useful for rendering the card or a collection of cards See the following diff for sample usage. Differential Revision: D59926999
mpolson64
force-pushed
the
export-D59926999
branch
from
d6469f9
to
8867384
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59926999 |
mpolson64
force-pushed
the
export-D59926999
branch
from
8867384
to
8190ee6
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jul 19, 2024
Summary: Pull Request resolved: facebook#2589 New structure for Analysis to make the Ax classes easier to reason about in light of storage considerations. The central change is to break up the existing Analysis class into **Analysis** (code for "how" a plot is to be generated) and **AnalysisCard** (the generated plot and its raw data). See N5607609 for demo. ## Analysis * Init method to take in "settings" (like which parameter or metrics to operate on, or whether to use observed or modeled effects) and store on class * compute method takes in Experiment or GenerationStrategy (or both) and outputs an AnalysisCard * Analysis is a Protocol to allow users to easily implement their own analyses structurally ## AnalysisCard * Contains the raw data computed by the analysis and a "blob" which holds data processed and ready for end-user consumption (ex. a plot) * Contains other miscellaneous metadata that can be useful for rendering the card or a collection of cards See the following diff for sample usage. Differential Revision: D59926999
|
This pull request was exported from Phabricator. Differential Revision: D59926999 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jul 19, 2024
Summary: Pull Request resolved: facebook#2589 New structure for Analysis to make the Ax classes easier to reason about in light of storage considerations. The central change is to break up the existing Analysis class into **Analysis** (code for "how" a plot is to be generated) and **AnalysisCard** (the generated plot and its raw data). See N5607609 for demo. ## Analysis * Init method to take in "settings" (like which parameter or metrics to operate on, or whether to use observed or modeled effects) and store on class * compute method takes in Experiment or GenerationStrategy (or both) and outputs an AnalysisCard * Analysis is a Protocol to allow users to easily implement their own analyses structurally ## AnalysisCard * Contains the raw data computed by the analysis and a "blob" which holds data processed and ready for end-user consumption (ex. a plot) * Contains other miscellaneous metadata that can be useful for rendering the card or a collection of cards See the following diff for sample usage. Differential Revision: D59926999
mpolson64
force-pushed
the
export-D59926999
branch
from
8190ee6
to
4083093
Compare
Summary: Refactor incoming Differential Revision: D59925220
Summary: Pull Request resolved: facebook#2589 New structure for Analysis to make the Ax classes easier to reason about in light of storage considerations. The central change is to break up the existing Analysis class into **Analysis** (code for "how" a plot is to be generated) and **AnalysisCard** (the generated plot and its raw data). See N5607609 for demo. ## Analysis * Init method to take in "settings" (like which parameter or metrics to operate on, or whether to use observed or modeled effects) and store on class * compute method takes in Experiment or GenerationStrategy (or both) and outputs an AnalysisCard * Analysis is a Protocol to allow users to easily implement their own analyses structurally ## AnalysisCard * Contains the raw data computed by the analysis and a "blob" which holds data processed and ready for end-user consumption (ex. a plot) * Contains other miscellaneous metadata that can be useful for rendering the card or a collection of cards See the following diff for sample usage. Differential Revision: D59926999
|
This pull request was exported from Phabricator. Differential Revision: D59926999 |
mpolson64
force-pushed
the
export-D59926999
branch
from
4083093
to
1016ef2
Compare
|
This pull request has been merged in 3a44dad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
New structure for Analysis to make the Ax classes easier to reason about in light of storage considerations. The central change is to break up the existing Analysis class into Analysis (code for "how" a plot is to be generated) and AnalysisCard (the generated plot and its raw data).
See N5607609 for demo.
Analysis
AnalysisCard
See the following diff for sample usage.
Differential Revision: D59926999