Update BestModelSelector to return a ModelSpec rather than the index #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60319307 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 495 495
Lines 47720 47721 +1
=======================================
+ Hits 45435 45436 +1
Misses 2285 2285 ☔ View full report in Codecov by Sentry. |
…acebook#2609) Summary: Pull Request resolved: facebook#2609 This will make it possible to experiment with BestModelSelectors that return a modified ModelSpec rather than picking between what was in the original list. Reviewed By: mgarrard Differential Revision: D60319307
|
This pull request was exported from Phabricator. Differential Revision: D60319307 |
saitcakmak
force-pushed
the
export-D60319307
branch
from
526e791
to
9edca13
Compare
|
This pull request has been merged in 57c9d18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This will make it possible to experiment with BestModelSelectors that return a modified ModelSpec rather than picking between what was in the original list.
Differential Revision: D60319307