Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalysisCard encoder/decoder refactor #2643

Closed
wants to merge 2 commits into from

Conversation

Cesar-Cardoso
Copy link
Contributor

Summary: Add encoder/decoder logic for AnalysisCard

Reviewed By: mpolson64

Differential Revision: D60316107

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60316107

Differential Revision: D60258359
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.29%. Comparing base (e459a08) to head (eff3685).

Files Patch % Lines
ax/storage/sqa_store/encoder.py 66.66% 2 Missing ⚠️
ax/storage/sqa_store/decoder.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
- Coverage   95.31%   95.29%   -0.02%     
==========================================
  Files         492      491       -1     
  Lines       47644    47552      -92     
==========================================
- Hits        45412    45317      -95     
- Misses       2232     2235       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:
Pull Request resolved: facebook#2643

Add encoder/decoder logic for `AnalysisCard`

Reviewed By: mpolson64

Differential Revision: D60316107
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60316107

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b67b5e3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants