Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQAAnalysisCard refactor #2644

Closed
wants to merge 1 commit into from

Conversation

Cesar-Cardoso
Copy link
Contributor

Summary:

  • Refactor SQAAnalysis -> SQAAnalysisCard
  • Delete SQAAnalysisReport and related encoders/decoders

Reviewed By: danielcohenlive

Differential Revision: D60258359

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60258359

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (e459a08) to head (9276eaa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   95.31%   95.30%   -0.02%     
==========================================
  Files         492      491       -1     
  Lines       47644    47542     -102     
==========================================
- Hits        45412    45310     -102     
  Misses       2232     2232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:
Pull Request resolved: facebook#2644

* Refactor `SQAAnalysis` -> `SQAAnalysisCard`
* Delete `SQAAnalysisReport` and related encoders/decoders

Reviewed By: danielcohenlive

Differential Revision: D60258359
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60258359

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a3debca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants