Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codemod pep585_imports #2648

Closed
wants to merge 1 commit into from
Closed

Conversation

mpolson64
Copy link
Contributor

Summary: No more from typing import ... (sometimes)!

Differential Revision: D60976146

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60976146

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60976146

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Aug 8, 2024
Summary:
Pull Request resolved: facebook#2648

No more `from typing import ...` (sometimes)!

Reviewed By: esantorella

Differential Revision: D60976146
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60976146

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Aug 8, 2024
Summary:
Pull Request resolved: facebook#2648

No more `from typing import ...` (sometimes)!

Reviewed By: esantorella

Differential Revision: D60976146
Summary:
Pull Request resolved: facebook#2648

No more `from typing import ...` (sometimes)!

Reviewed By: esantorella

Differential Revision: D60976146
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60976146

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.33055% with 20 lines in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (fd562d6) to head (5074793).

Files Patch % Lines
ax/plot/trace.py 20.00% 8 Missing ⚠️
ax/plot/bandit_rollout.py 0.00% 3 Missing ⚠️
ax/utils/flake8_plugins/docstring_checker.py 0.00% 3 Missing ⚠️
ax/exceptions/data_provider.py 0.00% 2 Missing ⚠️
ax/plot/diagnostic.py 66.66% 2 Missing ⚠️
ax/plot/marginal_effects.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2648   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files         493      493           
  Lines       47612    47637   +25     
=======================================
+ Hits        45360    45385   +25     
  Misses       2252     2252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 837e422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants