Log an exception rather than erroring out when data is found for metrics that are not attached to the experiment #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61544922 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2680 +/- ##
==========================================
- Coverage 95.29% 95.28% -0.01%
==========================================
Files 495 495
Lines 47773 47780 +7
==========================================
+ Hits 45523 45529 +6
- Misses 2250 2251 +1 ☔ View full report in Codecov by Sentry. |
…ics that are not attached to the experiment (facebook#2680) Summary: Pull Request resolved: facebook#2680 D57165887 added an error when modeling layer encountered data for metrics that are not attached to the experiment. Daniel has been seeing these errors in some use cases where it is non-trivial to attach these metrics to the experiment. In order to unblock, we are relaxing the error, and logging an exception instead. This should keep the issue visible while letting the experiment proceed. Reviewed By: danielcohenlive Differential Revision: D61544922
|
This pull request was exported from Phabricator. Differential Revision: D61544922 |
saitcakmak
force-pushed
the
export-D61544922
branch
from
559cc23 to
8e54ca2
Compare
|
This pull request has been merged in 6ac3aae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D57165887 added an error when modeling layer encountered data for metrics that are not attached to the experiment. Daniel has been seeing these errors in some use cases where it is non-trivial to attach these metrics to the experiment. In order to unblock, we are relaxing the error, and logging an exception instead. This should keep the issue visible while letting the experiment proceed.
Reviewed By: danielcohenlive
Differential Revision: D61544922