Simplify ax/analysis/plotly directory structure #2684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Having separate sub-directories for each analysis makes the directory structure & import paths overly verbose. It also necessitates adding an `__init__.py` file for each sub-directory, which is easy to miss and can lead to `module not found` errors elsewhere (see D61607199). This diff eliminates the separate sub-directory for the parallel coordinates analysis. Differential Revision: D61611408
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61611408 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2684 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 495 495
Lines 47832 47832
=======================================
Hits 45582 45582
Misses 2250 2250 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 8801c79. |
|
This caused a tutorial failure in botorch: https://github.com/pytorch/botorch/actions/runs/10495950816/job/29075527236 |
|
By fixing one issue, it unearthed a different issue :). Being fixed in #2692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Having separate sub-directories for each analysis makes the directory structure & import paths overly verbose. It also necessitates adding an
__init__.pyfile for each sub-directory, which is easy to miss and can lead tomodule not founderrors elsewhere (see D61607199).This diff eliminates the separate sub-directory for the parallel coordinates analysis.
Differential Revision: D61611408