Deprecate no_bayesian_optimization argument in favor of force_random_search
#2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
- Coverage 95.29% 95.28% -0.01%
==========================================
Files 492 493 +1
Lines 47852 47861 +9
==========================================
+ Hits 45599 45605 +6
- Misses 2253 2256 +3 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
ltiao
force-pushed
the
export-D61601511
branch
from
278d8e0
to
e5699ac
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 22, 2024
…om_search` (facebook#2693) Summary: Pull Request resolved: facebook#2693 This deprecates the `no_bayesian_optimization` argument in favor of `force_random_search`. It is a "soft" deprecation in which we continue to provide support for the `no_bayesian_optimization` argument, but we turn it into an *optional* one and raise a deprecation warning when it is specified explicitly by the user. If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task T199632397. - In the `GenerationStrategyConfig` dataclass we turned `no_bayesian_optimization` into an [init-only variable](https://docs.python.org/3/library/dataclasses.html#init-only-variables) (so it no longer become a "field"). - Everywhere that it appears as an argument, `no_bayesian_optimization` is now an *optional* argument with a default value of `None`. Whenever it is not `None`, we raise a deprecation warning and, whenever its value conflicts with `force_random_search` (non-optional, default `False`), we raise a `ValueError`. Differential Revision: D61601511
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 22, 2024
…om_search` (facebook#2693) Summary: Pull Request resolved: facebook#2693 This deprecates the `no_bayesian_optimization` argument in favor of `force_random_search`. It is a "soft" deprecation in which we continue to provide support for the `no_bayesian_optimization` argument, but we turn it into an *optional* one and raise a deprecation warning when it is specified explicitly by the user. If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task T199632397. - In the `GenerationStrategyConfig` dataclass we turned `no_bayesian_optimization` into an [init-only variable](https://docs.python.org/3/library/dataclasses.html#init-only-variables) (so it no longer become a "field"). - Everywhere that it appears as an argument, `no_bayesian_optimization` is now an *optional* argument with a default value of `None`. Whenever it is not `None`, we raise a deprecation warning and, whenever its value conflicts with `force_random_search` (non-optional, default `False`), we raise a `ValueError`. Differential Revision: D61601511
ltiao
force-pushed
the
export-D61601511
branch
from
e5699ac
to
d9120f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 23, 2024
…om_search` (facebook#2693) Summary: Pull Request resolved: facebook#2693 This deprecates the `no_bayesian_optimization` argument in favor of `force_random_search`. It is a "soft" deprecation in which we continue to provide support for the `no_bayesian_optimization` argument, but we turn it into an *optional* one and raise a deprecation warning when it is specified explicitly by the user. If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task T199632397. - In the `GenerationStrategyConfig` dataclass we turned `no_bayesian_optimization` into an [init-only variable](https://docs.python.org/3/library/dataclasses.html#init-only-variables) (so it no longer become a "field"). - Everywhere that it appears as an argument, `no_bayesian_optimization` is now an *optional* argument with a default value of `None`. Whenever it is not `None`, we raise a deprecation warning and, whenever its value conflicts with `force_random_search` (non-optional, default `False`), we raise a `ValueError`. Differential Revision: D61601511
ltiao
force-pushed
the
export-D61601511
branch
from
d9120f2
to
71bba9c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 23, 2024
…om_search` (facebook#2693) Summary: Pull Request resolved: facebook#2693 This deprecates the `no_bayesian_optimization` argument in favor of `force_random_search`. It is a "soft" deprecation in which we continue to provide support for the `no_bayesian_optimization` argument, but we turn it into an *optional* one and raise a deprecation warning when it is specified explicitly by the user. If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task T199632397. - In the `GenerationStrategyConfig` dataclass we turned `no_bayesian_optimization` into an [init-only variable](https://docs.python.org/3/library/dataclasses.html#init-only-variables) (so it no longer become a "field"). - Everywhere that it appears as an argument, `no_bayesian_optimization` is now an *optional* argument with a default value of `None`. Whenever it is not `None`, we raise a deprecation warning and, whenever its value conflicts with `force_random_search` (non-optional, default `False`), we raise a `ValueError`. Differential Revision: D61601511
ltiao
force-pushed
the
export-D61601511
branch
from
71bba9c
to
d7e7365
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
ltiao
force-pushed
the
export-D61601511
branch
from
d7e7365
to
16b2e5f
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 23, 2024
…om_search` (facebook#2693) Summary: Pull Request resolved: facebook#2693 This deprecates the `no_bayesian_optimization` argument in favor of `force_random_search`. It is a "soft" deprecation in which we continue to provide support for the `no_bayesian_optimization` argument, but we turn it into an *optional* one and raise a deprecation warning when it is specified explicitly by the user. If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task T199632397. - In the `GenerationStrategyConfig` dataclass we turned `no_bayesian_optimization` into an [init-only variable](https://docs.python.org/3/library/dataclasses.html#init-only-variables) (so it no longer become a "field"). - Everywhere that it appears as an argument, `no_bayesian_optimization` is now an *optional* argument with a default value of `None`. Whenever it is not `None`, we raise a deprecation warning and, whenever its value conflicts with `force_random_search` (non-optional, default `False`), we raise a `ValueError`. Differential Revision: D61601511
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 23, 2024
…om_search` (facebook#2693) Summary: Pull Request resolved: facebook#2693 This deprecates the `no_bayesian_optimization` argument in favor of `force_random_search`. It is a "soft" deprecation in which we continue to provide support for the `no_bayesian_optimization` argument, but we turn it into an *optional* one and raise a deprecation warning when it is specified explicitly by the user. If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task T199632397. - In the `GenerationStrategyConfig` dataclass we turned `no_bayesian_optimization` into an [init-only variable](https://docs.python.org/3/library/dataclasses.html#init-only-variables) (so it no longer become a "field"). - Everywhere that it appears as an argument, `no_bayesian_optimization` is now an *optional* argument with a default value of `None`. Whenever it is not `None`, we raise a deprecation warning and, whenever its value conflicts with `force_random_search` (non-optional, default `False`), we raise a `ValueError`. Differential Revision: D61601511
ltiao
force-pushed
the
export-D61601511
branch
from
16b2e5f
to
5358d40
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
…om_search` (facebook#2693) Summary: Pull Request resolved: facebook#2693 This deprecates the `no_bayesian_optimization` argument in favor of `force_random_search`. It is a "soft" deprecation in which we continue to provide support for the `no_bayesian_optimization` argument, but we turn it into an *optional* one and raise a deprecation warning when it is specified explicitly by the user. If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task T199632397. - In the `GenerationStrategyConfig` dataclass we turned `no_bayesian_optimization` into an [init-only variable](https://docs.python.org/3/library/dataclasses.html#init-only-variables) (so it no longer become a "field"). - Everywhere that it appears as an argument, `no_bayesian_optimization` is now an *optional* argument with a default value of `None`. Whenever it is not `None`, we raise a deprecation warning and, whenever its value conflicts with `force_random_search` (non-optional, default `False`), we raise a `ValueError`. Differential Revision: D61601511
|
This pull request was exported from Phabricator. Differential Revision: D61601511 |
ltiao
force-pushed
the
export-D61601511
branch
from
5358d40
to
6c9f7d7
Compare
|
This pull request has been merged in 9c2fa96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This deprecates the
no_bayesian_optimizationargument in favor offorce_random_search. It is a "soft" deprecation in which we continue to provide support for theno_bayesian_optimizationargument, but we turn it into an optional one and raise a deprecation warning when it is specified explicitly by the user.If this soft deprecation does not start any fires in the coming few weeks, we will move forward with a "hard" deprecation in follow-up task [insert link to task here].
GenerationStrategyConfigdataclass we turnedno_bayesian_optimizationinto an init-only variable (so it no longer become a "field").no_bayesian_optimizationis now an optional argument with a default value ofNone. Whenever it is notNone, we raise a deprecation warning and, whenever its value conflicts withforce_random_search(non-optional, defaultFalse), we raise aValueError.Differential Revision: D61601511