Consolidate BenchmarkMetric functionality in one file
#2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 95.39% 95.39% -0.01%
==========================================
Files 492 490 -2
Lines 47920 47738 -182
==========================================
- Hits 45715 45541 -174
+ Misses 2205 2197 -8 ☔ View full report in Codecov by Sentry. |
facebook-github-bot
added
the
CLA Signed
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Differential Revision: D61404056 Reviewed By: saitcakmak
Summary: Pull Request resolved: facebook#2706 No longer needed after the changes in the previous diff. Differential Revision: D61415525 Reviewed By: Balandat
Summary: There is no need to have multiple files here anymore now that a lot of BenchmarkMetric functionality has disappeared. D61736027 follows up by moving `benchmark/metrics/benchmark.py` to `benchmark/benchmark_metric.py` and moving the corresponding test file. Reviewed By: Balandat Differential Revision: D61432000
|
This pull request was exported from Phabricator. Differential Revision: D61432000 |
esantorella
force-pushed
the
export-D61432000
branch
from
f08058d
to
09150d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61432000 |
|
This pull request has been merged in 3e2e290. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is no need to have multiple files here anymore now that a lot of BenchmarkMetric functionality has disappeared.
D61736027 follows up by moving
benchmark/metrics/benchmark.pytobenchmark/benchmark_metric.pyand moving the corresponding test file.Reviewed By: Balandat
Differential Revision: D61432000