Do not override metric name by default #2718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61852855 |
|
This pull request was exported from Phabricator. Differential Revision: D61852855 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebook#2718 Differential Revision: D61852855
danielcohenlive
force-pushed
the
export-D61852855
branch
from
b50f059
to
69e9df9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2718 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 490 490
Lines 47822 47824 +2
=======================================
+ Hits 45625 45627 +2
Misses 2197 2197 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61852855 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebook#2718 Differential Revision: D61852855
danielcohenlive
force-pushed
the
export-D61852855
branch
from
69e9df9
to
502260f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61852855 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: facebook#2718 Differential Revision: D61852855
danielcohenlive
force-pushed
the
export-D61852855
branch
from
502260f
to
cdba95c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61852855 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebook#2718 Simplify code. Also references to super should help deobscure where this gets called/ Differential Revision: D61852855
danielcohenlive
force-pushed
the
export-D61852855
branch
from
cdba95c
to
9f9dbba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61852855 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#2718 Simplify code. Also references to super should help deobscure where this gets called/ Reviewed By: sdaulton Differential Revision: D61852855
danielcohenlive
force-pushed
the
export-D61852855
branch
from
9f9dbba
to
b29c18c
Compare
Summary: Pull Request resolved: facebook#2718 Simplify code. Also references to super should help deobscure where this gets called/ Reviewed By: sdaulton Differential Revision: D61852855
|
This pull request was exported from Phabricator. Differential Revision: D61852855 |
danielcohenlive
force-pushed
the
export-D61852855
branch
from
b29c18c
to
7ca9724
Compare
|
This pull request has been merged in 89ae083. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D61852855