Ensure new arm names do not match a different name on the experiment #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62130255 |
|
This pull request was exported from Phabricator. Differential Revision: D62130255 |
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Sep 3, 2024
…acebook#2732) Summary: Pull Request resolved: facebook#2732 > In Experiment._name_and_store_arm_if_not_exists (pointer)`, ensure that no other arm with a different signature (but same name) exists on the experiment before adding. This change checks for signature conflict by arm name in Experiment._name_and_store_arm_if_not_exists. A "replace" flag is also added, to maintain the existing functionality where a conflicting arm by the same name existed. => In "clone_with", desired functionality is to replace existing status quo arm with new status quo arm. Differential Revision: D62130255
mgrange1998
force-pushed
the
export-D62130255
branch
from
d85c0ea
to
7556016
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 489 489
Lines 47838 47861 +23
=======================================
+ Hits 45671 45694 +23
Misses 2167 2167 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D62130255 |
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Sep 3, 2024
…acebook#2732) Summary: Pull Request resolved: facebook#2732 > In Experiment._name_and_store_arm_if_not_exists (pointer)`, ensure that no other arm with a different signature (but same name) exists on the experiment before adding. This change checks for signature conflict by arm name in Experiment._name_and_store_arm_if_not_exists. ## Replacement support In "clone_with", desired functionality is to replace existing status quo arm with new status quo arm. A "replace" flag is also added, so that a signature conflict of same-named arms will not be errored out. Differential Revision: D62130255
mgrange1998
force-pushed
the
export-D62130255
branch
from
7556016
to
485554e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62130255 |
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Sep 3, 2024
…acebook#2732) Summary: Pull Request resolved: facebook#2732 > In Experiment._name_and_store_arm_if_not_exists (pointer)`, ensure that no other arm with a different signature (but same name) exists on the experiment before adding. This change checks for signature conflict by arm name in Experiment._name_and_store_arm_if_not_exists. ## Replacement support In "clone_with", desired functionality is to replace existing status quo arm with new status quo arm. A "replace" flag is also added, so that a signature conflict of same-named arms will not be errored out. Reviewed By: mpolson64 Differential Revision: D62130255
mgrange1998
force-pushed
the
export-D62130255
branch
from
485554e
to
284b512
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62130255 |
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Sep 3, 2024
…acebook#2732) Summary: Pull Request resolved: facebook#2732 > In Experiment._name_and_store_arm_if_not_exists (pointer)`, ensure that no other arm with a different signature (but same name) exists on the experiment before adding. This change checks for signature conflict by arm name in Experiment._name_and_store_arm_if_not_exists. ## Replacement support In "clone_with", desired functionality is to replace existing status quo arm with new status quo arm. A "replace" flag is also added, so that a signature conflict of same-named arms will not be errored out. Reviewed By: mpolson64 Differential Revision: D62130255
mgrange1998
force-pushed
the
export-D62130255
branch
from
284b512
to
eafee45
Compare
…acebook#2732) Summary: Pull Request resolved: facebook#2732 > In Experiment._name_and_store_arm_if_not_exists (pointer)`, ensure that no other arm with a different signature (but same name) exists on the experiment before adding. This change checks for signature conflict by arm name in Experiment._name_and_store_arm_if_not_exists. ## Replacement support In "clone_with", desired functionality is to replace existing status quo arm with new status quo arm. A "replace" flag is also added, so that a signature conflict of same-named arms will not be errored out. Reviewed By: mpolson64 Differential Revision: D62130255
|
This pull request was exported from Phabricator. Differential Revision: D62130255 |
mgrange1998
force-pushed
the
export-D62130255
branch
from
eafee45
to
35a2ee3
Compare
|
This pull request has been merged in 76d1db6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In Experiment._name_and_store_arm_if_not_exists (pointer)`, ensure that no other arm with a different signature (but same name) exists on the experiment before adding.
This change checks for signature conflict by arm name in Experiment._name_and_store_arm_if_not_exists
Differential Revision: D62130255