Update docstrings and type annotations #2746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: * Expand docstrings * `is_moo` syntatactic sugar * Use mutable annotations where appropriate * Have `BenchmarkRunner.evaluate_oracle` return a Numpy arrray rather than a tensor (broader detorchification would be good) * Differential Revision: D62246721
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62246721 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2746 +/- ##
==========================================
- Coverage 95.47% 95.47% -0.01%
==========================================
Files 489 489
Lines 47871 47876 +5
==========================================
+ Hits 45707 45709 +2
- Misses 2164 2167 +3 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in f343dbd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
is_moosyntatactic sugarBenchmarkRunner.evaluate_oraclereturn a Numpy arrray rather than a tensor (broader detorchification would be good)Differential Revision: D62246721