add remaining n input constructor #2758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62467907 |
|
This pull request was exported from Phabricator. Differential Revision: D62467907 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebook#2758 This diff adds the input constructor for our default logic for repeat arms. See note in comments about how this new logic differs Follow up diffs: - update the transition logic to leverage this - storage --> let's do this once we all like the 3 input constructors - update the input constructors to handle the case where n isn't provided as a kwarg - add tests for real world scenario per Liz suggestion - add test to enforce signature across input constructors per Liz/Sait/Daniel suggestion Differential Revision: D62467907
mgarrard
force-pushed
the
export-D62467907
branch
from
cd76008
to
1d685ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
=======================================
Coverage 95.67% 95.68%
=======================================
Files 486 488 +2
Lines 47713 47802 +89
=======================================
+ Hits 45650 45738 +88
- Misses 2063 2064 +1 ☔ View full report in Codecov by Sentry. |
added 3 commits
September 23, 2024 11:18
…t at 9/6/2024, 10:19:43 AM Differential Revision: D62247100
Summary: todo Differential Revision: D62310414
Summary: todo Differential Revision: D62252945
|
This pull request was exported from Phabricator. Differential Revision: D62467907 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 23, 2024
Summary: Pull Request resolved: facebook#2758 This diff adds the input constructor for our default logic for repeat arms. See note in comments about how this new logic differs Follow up diffs: - update the transition logic to leverage this - storage --> let's do this once we all like the 3 input constructors - update the input constructors to handle the case where n isn't provided as a kwarg - add tests for real world scenario per Liz suggestion - add test to enforce signature across input constructors per Liz/Sait/Daniel suggestion Reviewed By: lena-kashtelyan Differential Revision: D62467907
mgarrard
force-pushed
the
export-D62467907
branch
from
1d685ac
to
3019c8a
Compare
Summary: Pull Request resolved: facebook#2758 This diff adds the input constructor for our default logic for repeat arms. See note in comments about how this new logic differs Follow up diffs: - update the transition logic to leverage this - storage --> let's do this once we all like the 3 input constructors - update the input constructors to handle the case where n isn't provided as a kwarg - add tests for real world scenario per Liz suggestion - add test to enforce signature across input constructors per Liz/Sait/Daniel suggestion Reviewed By: lena-kashtelyan Differential Revision: D62467907
|
This pull request was exported from Phabricator. Differential Revision: D62467907 |
mgarrard
force-pushed
the
export-D62467907
branch
from
3019c8a
to
d986cad
Compare
|
This pull request has been merged in a880c3a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the input constructor for our default logic for repeat arms. See note in comments about how this new logic differs
Follow up diffs:
Differential Revision: D62467907