Bug fix: Make Acquisition.optimize work with discrete optimizer regardless of whether raw_samples is in optimizer_options
#2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ardless of whether `raw_samples` is in `optimizer_options` Summary: Context: When `raw_samples` is present in `optimizer_options` and the discrete optimizer is used, `raw_samples` is removed from `optimizer_options` because it isn't appropriate for for the discrete optimizer. However, `raw_samples` can't be removed if it isn't present. Not passing it (which is better) causes an error. This PR: Doesn't try to remove `raw_samples` when it isn't present. Reviewed By: saitcakmak Differential Revision: D63035021
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63035021 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 486 486
Lines 47709 47712 +3
=======================================
+ Hits 45645 45649 +4
+ Misses 2064 2063 -1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 3de05de. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: When
raw_samplesis present inoptimizer_optionsand the discrete optimizer is used,raw_samplesis removed fromoptimizer_optionsbecause it isn't appropriate for for the discrete optimizer. However,raw_samplescan't be removed if it isn't present. Not passing it (which is better) causes an error.This PR: Doesn't try to remove
raw_sampleswhen it isn't present.Reviewed By: saitcakmak
Differential Revision: D63035021