Indicate constraint violations in predicted effects plot #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 95.72% 95.72% -0.01%
==========================================
Files 490 490
Lines 48440 48514 +74
==========================================
+ Hits 46369 46438 +69
- Misses 2071 2076 +5 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
force-pushed
the
export-D63290929
branch
from
2b72426
to
8e20788
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
danielcohenlive
force-pushed
the
export-D63290929
branch
from
8e20788
to
4b32be3
Compare
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
danielcohenlive
force-pushed
the
export-D63290929
branch
from
4b32be3
to
f2b7294
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
danielcohenlive
force-pushed
the
export-D63290929
branch
from
f2b7294
to
e4372c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
danielcohenlive
force-pushed
the
export-D63290929
branch
from
e4372c9
to
679fa8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
danielcohenlive
force-pushed
the
export-D63290929
branch
from
679fa8b
to
96ee0fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
danielcohenlive
force-pushed
the
export-D63290929
branch
2 times, most recently
from
d2ce694
to
a898ac6
Compare
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
force-pushed
the
export-D63290929
branch
from
a898ac6
to
7560257
Compare
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
Summary: Pull Request resolved: facebook#2783 Points that may violate any constraint should be marked with an x instead of a circle. On hover it should indicate the % chance that the arm violates the given constraint. Reviewed By: SebastianAment Differential Revision: D63290929
|
This pull request was exported from Phabricator. Differential Revision: D63290929 |
danielcohenlive
force-pushed
the
export-D63290929
branch
from
7560257
to
4f9c22e
Compare
|
This pull request has been merged in c38c386. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Points that may violate any constraint should be marked with an x instead of a circle.
On hover it should indicate the % chance that the arm violates the given constraint.
Differential Revision: D63290929