Add storage for input constructors #2785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62652950 |
Summary: Pull Request resolved: facebook#2785 This diff adds storage support for the input constructors that we've implemented throughout this stack (diffs 11-19). As part of this update for storage we do a few things: 1. updated NodeInputConstructors enum to store a string and then modified the call method to use that string to link to the correct method. We do this to avoid some strange behavior related to stroing the function as the enum value directly, namely being it's not registring as a enum but instead only the function. 2. Added some additional tests Reviewed By: lena-kashtelyan Differential Revision: D62652950
|
This pull request was exported from Phabricator. Differential Revision: D62652950 |
mgarrard
force-pushed
the
export-D62652950
branch
from
03888f8
to
35fdaef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
==========================================
- Coverage 95.68% 95.68% -0.01%
==========================================
Files 488 488
Lines 47843 47856 +13
==========================================
+ Hits 45779 45791 +12
- Misses 2064 2065 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds storage support for the input constructors that we've implemented throughout this stack (diffs 11-19). As part of this update for storage we do a few things:
Reviewed By: lena-kashtelyan
Differential Revision: D62652950