Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce trial_indices argument to SupervisedDataset #2960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bernardbeckerman
Copy link
Contributor

Summary: Adds optional trial_indices to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in _validate (pointer).

Differential Revision: D64764019

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64764019

bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Oct 25, 2024
Summary:

X-link: pytorch/botorch#2595

Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64764019

bernardbeckerman added a commit to bernardbeckerman/botorch that referenced this pull request Oct 25, 2024
Summary:
X-link: facebook/Ax#2960


Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
bernardbeckerman added a commit to bernardbeckerman/botorch that referenced this pull request Oct 25, 2024
Summary:
X-link: facebook/Ax#2960


Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Oct 25, 2024
Summary:

X-link: pytorch/botorch#2595

Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64764019

bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Oct 25, 2024
Summary:

X-link: pytorch/botorch#2595

Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64764019

bernardbeckerman added a commit to bernardbeckerman/botorch that referenced this pull request Oct 25, 2024
Summary:
X-link: facebook/Ax#2960


Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
bernardbeckerman added a commit to bernardbeckerman/botorch that referenced this pull request Oct 25, 2024
Summary:
X-link: facebook/Ax#2960


Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
Summary:

X-link: pytorch/botorch#2595

Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)).

Reviewed By: Balandat

Differential Revision: D64764019
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64764019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants