Include progression information as metadata when transforming Data to Observations #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3001 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 504 504
Lines 50404 50389 -15
=======================================
- Hits 48131 48118 -13
+ Misses 2273 2271 -2 ☔ View full report in Codecov by Sentry. |
ltiao
force-pushed
the
export-D65255312
branch
from
ceb2293
to
f81fb7a
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 4, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 Differential Revision: D65255312
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 4, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
f81fb7a
to
df30af6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
force-pushed
the
export-D65255312
branch
from
df30af6
to
b935f7b
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 5, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 5, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
b935f7b
to
53b9e96
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 5, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 7, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 8, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
53b9e96
to
854fc50
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 23, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 25, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 25, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
854fc50
to
8f94586
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
8f94586
to
94d62c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
94d62c1
to
54a24b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D65255312