Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reap completion_criterion method #3092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reap completion_criterion method #3092

wants to merge 1 commit into from

Commits on Nov 27, 2024

  1. Reap completion_criterion method (facebook#3092) 

    Summary:

As titled - this diff moves the logic from `completion_criterion` to `should_consider_optimization_complete`

Cleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v

Differential Revision: D66245238
    @paschai @facebook-github-bot
    paschai authored and facebook-github-bot committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0f67475 View commit details
    Browse the repository at this point in the history