Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving EBAshr to oss #3276

Closed

Conversation

jelena-markovic
Copy link
Contributor

Summary: Moving EBAshr along with Ashr utils to OSS. This model is used for repeating arms in online experiments as well as regression analysis in the health checks.

Reviewed By: mgarrard

Differential Revision: D68562504

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68562504

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.01%. Comparing base (124f6e6) to head (e42f1b0).

Files with missing lines Patch % Lines
ax/models/discrete/ashr_utils.py 94.11% 5 Missing ⚠️
ax/models/discrete/eb_ashr.py 97.22% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3276    +/-   ##
========================================
  Coverage   96.01%   96.01%            
========================================
  Files         512      516     +4     
  Lines       51725    51997   +272     
========================================
+ Hits        49663    49927   +264     
- Misses       2062     2070     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:
Pull Request resolved: facebook#3276

Moving EBAshr along with Ashr utils to OSS. This model is used for repeating arms in online experiments as well as regression analysis in the health checks.

Reviewed By: mgarrard

Differential Revision: D68562504
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68562504

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in febc018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants