Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Increased the fiber stack size to 64KB
Summary: During the release testing (https://fburl.com/conveyor/a16yhrk4), tasks were crashing mostly by SIGSEGV and SIGABRT. From the further analysis, it is suspected that the destructor calls from the fiber run by the Navy's region_manager thread are causing random memory corruptions. In order to fix this issue, this change increases the stack size of fibers used by the NavyThread to 64KB. The increases in the stack memory usage would not be an issue for region_manager for now because the number of fibers are bound by the number of clean regions, so the stack overhead will be bound by the preallocated guard page stacks (100 by default); i.e., 64KB x 100 = 64MB. Reviewed By: therealgymmy Differential Revision: D50756161 fbshipit-source-id: 9c110504f51a2822e108571dbbf57f5d7aecb98b
- Loading branch information