Extend memory tier configs to cache allocator based on NUMA bindings #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add in MemoryTier tests - Increase max number of tiers to 2 for tiers tests
facebook-github-bot
added
the
CLA Signed
Comment on lines
+1267
to
+1268
| if (cfgs.size()) | ||
| config.configureMemoryTiers(cfgs); |
There was a problem hiding this comment.
nit
if (cfgs.size()) {
config.configureMemoryTiers(cfgs);
}
|
@therealgymmy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@therealgymmy merged this pull request in b43ae59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add support for NUMA bindings to the memory tier config that was upstreamed in #138
A quick summary of the PR is: