Skip to content

Chained item cannot be larger than 4MB #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Chained item cannot be larger than 4MB #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55444c0
modify docs
xiedeyantu Dec 2, 2021
84766d8
Merge branch 'main' of https://github.com/xiedeyantu/CacheLib into main
xiedeyantu Dec 2, 2021
cc3ee85
modify docs
xiedeyantu Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cachelib/allocator/CacheItem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,8 @@ class CACHELIB_PACKED_ATTR CacheItem {
// | a | | y | |
// | t | | l | |
// | i | | o | |
// | o | | d | |
// | n | | | |
// | o | | a | |
// | n | | d | |
// | --------------------- |
template <typename CacheTrait>
class CACHELIB_PACKED_ATTR CacheChainedItem : public CacheItem<CacheTrait> {
Expand Down
8 changes: 5 additions & 3 deletions website/docs/Cache_Library_User_Guides/Write_data_to_cache.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,11 @@ auto parent_item_handle = cache->allocate(pool_id, "parent", size);

if (parent_item_handle) {
// Call allocateChainedItem() to allocate memory for 3 chained items.
auto chained_item_handle_1 = cache->allocateChainedItem(parent_item_handle, 2 * size);
auto chained_item_handle_2 = cache->allocateChainedItem(parent_item_handle, 4 * size);
auto chained_item_handle_3 = cache->allocateChainedItem(parent_item_handle, 6 * size);
// 4 * size is invalid, Because there are other costs, see getRequiredSize().
// But you can create more chained items.
auto chained_item_handle_1 = cache->allocateChainedItem(parent_item_handle, 1 * size);
auto chained_item_handle_2 = cache->allocateChainedItem(parent_item_handle, 2 * size);
auto chained_item_handle_3 = cache->allocateChainedItem(parent_item_handle, 3 * size);
}
```

Expand Down
2 changes: 1 addition & 1 deletion website/docs/Cache_Library_User_Guides/chained_items.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ std::unique_ptr<LargeUserData> userData = getLargeUserData();
size_t userDataSize = sizeof(LargeUserData) + sizeof(int) * userData->length;

// For simplicity, we'll split the user data into 1MB chunks
size_t numChunks = userDataSize / (1024 * 1024 * 1024);
size_t numChunks = userDataSize / (1024 * 1024);

struct CustomParentItem {
size_t numChunks;
Expand Down