Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pytx] Move ContentTypeConfig to python-threatexchange/threatexchange/storage/interfaces.py #1702

Merged
merged 5 commits into from
Dec 2, 2024
Merged

[Pytx] Move ContentTypeConfig to python-threatexchange/threatexchange/storage/interfaces.py #1702

merged 5 commits into from
Dec 2, 2024

Conversation

haianhng31
Copy link
Contributor

Summary

  • This resolves the 1st part of issue [py-tx][mlh] Move IContentTypeConfigStore from HMA to python-threatexchange #1688
  • I'm not sure if I should change anything. Right now, I'm merely copying everything from HMA's storage/interface.py to python-threatexchange/threatexchange/storage/interfaces.py (please let me know if i should make any adjustments).
  • Also, for the next step of bumping the minor version of python-threatexchange, I would like to have some guidance as well!

@haianhng31 haianhng31 requested a review from Dcallies as a code owner November 29, 2024 22:41
Dcallies
Dcallies approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dcallies Dcallies merged commit 982e547 into facebook:main Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dcallies Dcallies Dcallies approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haianhng31 @Dcallies @facebook-github-bot