This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
More pex fixes for windows. #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from the two issues @sdwilsh found, the last bit was convincing pex to not remove sys.prefix from sys.path.
| else: | ||
| raise | ||
| safe_copy(abs_src, abs_dst, overwrite=False) | ||
| # If the file already exists, skip XXX -- ensure target and dest are same? |
There was a problem hiding this comment.
We can actually avoid this path entirely if we just modify the code in src/com/facebook/buck/python/make_pex.py to prefer to copy on Windows. I had originally wrote something like this, but @andrewjcg suggested changing Buck's code so it was fewer changes to PEX itself.
There was a problem hiding this comment.
I'm actually going to try to upstream these in pex-tool/pex#198
|
Just want you to address the first comment. Thanks! |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/116871295358869/int_phab to review. |
ghost
closed this
in
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the two issues @sdwilsh found, the last bit was convincing pex to not remove sys.prefix from sys.path.