Skip to content

Commit

Permalink
fix cache_links for target platform
Browse files Browse the repository at this point in the history
Summary:
Motivation: In order to disable remote linking in RL zhongjianluxian have done some work D60529117 disabling `cache_links`. Unfortunately those changes did't take any affect  because of the bug fixed in this diff.

The code fixed in this diff was initially introduced to to enable `cache_links` for execution platform only. (cc scottcao who has more context). Unfortunately it affects target platform as well. So this diff if fixing it.

Reviewed By: scottcao

Differential Revision: D61659969

fbshipit-source-id: 8d60f251125e4fc4dfc5d703d6ade275622bb054
  • Loading branch information
Yury Samkevich authored and facebook-github-bot committed Aug 31, 2024
1 parent ae4bf0d commit aeb0397
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions native.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,7 @@ def _cxx_toolchain_macro_stub(**kwargs):
cache_links = kwargs.get("cache_links")
kwargs["cache_links"] = select({
"DEFAULT": cache_links,
"ovr_config//build_mode:fbcode-build-info-mode-disable": True,
"ovr_config//build_mode:fbcode-build-info-mode-full": False,
"ovr_config//build_mode:fbcode-build-info-mode-stable": True,
"ovr_config//platform/execution/constraints:execution-platform-transitioned": True,
})
cxx_toolchain_macro_impl(
cxx_toolchain_rule = cxx_toolchain_inheriting_target_platform,
Expand Down

0 comments on commit aeb0397

Please sign in to comment.