Skip to content

Commit

Permalink
Bundling: fix incremental bundling config
Browse files Browse the repository at this point in the history
Summary: Fix `apple.incremental_bundling_enabled` buckconfig not working correctly.

Reviewed By: manicaesar

Differential Revision: D65267646

fbshipit-source-id: 4c6e09994bed79d4054ce386148c4bbc69413fc2
  • Loading branch information
milend authored and facebook-github-bot committed Oct 31, 2024
1 parent 751dccb commit effd264
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions apple/apple_bundle.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -340,10 +340,10 @@ def apple_bundle_impl(ctx: AnalysisContext) -> list[Provider]:

validation_deps_outputs = get_validation_deps_outputs(ctx)

should_enable_incremental_bundling = True
incremental_bundling_override = None
sdk_name = get_apple_sdk_name(ctx)
if sdk_name == MacOSXSdkMetadata.name or sdk_name == MacOSXCatalystSdkMetadata.name:
should_enable_incremental_bundling = False
incremental_bundling_override = False

bundle_result = assemble_bundle(
ctx,
Expand All @@ -352,7 +352,7 @@ def apple_bundle_impl(ctx: AnalysisContext) -> list[Provider]:
apple_bundle_part_list_output.info_plist_part,
SwiftStdlibArguments(primary_binary_rel_path = primary_binary_rel_path),
validation_deps_outputs,
incremental_bundling_override = should_enable_incremental_bundling,
incremental_bundling_override = incremental_bundling_override,
)
sub_targets = bundle_result.sub_targets
sub_targets.update(aggregated_debug_info.sub_targets)
Expand Down

0 comments on commit effd264

Please sign in to comment.