-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuckEvent: provide a Buck Event Publisher proto #685
Open
sluongng
wants to merge
1
commit into
facebook:main
Choose a base branch
from
sluongng:sluongng/event-publisher
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
load("@fbcode//buck2:proto_defs.bzl", "rust_protobuf_library") | ||
load("@fbsource//tools/build_defs:glob_defs.bzl", "glob") | ||
|
||
oncall("build_infra") | ||
|
||
rust_protobuf_library( | ||
name = "buck2_event_publisher_proto", | ||
srcs = glob(["src/**/*.rs"]), | ||
build_script = "build.rs", | ||
build_env = { | ||
"BUCK_HACK_DATA_PROTOC_INCLUDE": "$(location //buck2/app/buck2_data:data_proto)", | ||
}, | ||
protos = ["event_publisher.proto"], | ||
deps = [ | ||
"fbsource//third-party/rust:tonic", | ||
"//buck2/app/buck2_data:buck2_data", | ||
], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
[package] | ||
name = "buck2_event_publisher_proto" | ||
|
||
edition = "2021" | ||
license = { workspace = true } | ||
repository = { workspace = true } | ||
version = "0.1.0" | ||
|
||
[dependencies] | ||
prost = { workspace = true } | ||
tonic = { workspace = true } | ||
|
||
buck2_data = { workspace = true } | ||
|
||
[build-dependencies] | ||
buck2_protoc_dev = { workspace = true } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under both the MIT license found in the | ||
* LICENSE-MIT file in the root directory of this source tree and the Apache | ||
* License, Version 2.0 found in the LICENSE-APACHE file in the root directory | ||
* of this source tree. | ||
*/ | ||
|
||
use std::env; | ||
use std::io; | ||
use std::path::PathBuf; | ||
|
||
fn main() -> io::Result<()> { | ||
let proto_files = &["event_publisher.proto"]; | ||
|
||
let data_include = if let Ok(value) = env::var("BUCK_HACK_DATA_PROTOC_INCLUDE") { | ||
let path = PathBuf::from(value); | ||
path.parent().unwrap().to_str().unwrap().to_owned() | ||
} else { | ||
"../buck2_data".to_owned() | ||
}; | ||
|
||
buck2_protoc_dev::configure() | ||
.setup_protoc() | ||
.extern_path(".buck.data", "::buck2_data") | ||
.compile(proto_files, &[".", &data_include]) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under both the MIT license found in the | ||
* LICENSE-MIT file in the root directory of this source tree and the Apache | ||
* License, Version 2.0 found in the LICENSE-APACHE file in the root directory | ||
* of this source tree. | ||
*/ | ||
|
||
syntax = "proto3"; | ||
|
||
import "data.proto"; | ||
|
||
package event_publisher; | ||
|
||
message BuckEventRequest { | ||
// A trace-unique 64-bit identifying the stream. | ||
uint64 stream_id = 1; | ||
|
||
buck.data.BuckEvent event = 2; | ||
}; | ||
|
||
message BuckEventResponse { | ||
// A trace-unique 64-bit identifying the stream. | ||
uint64 stream_id = 1; | ||
|
||
// The trace ID of the event that has been committed. | ||
uint64 trace_id = 2; | ||
}; | ||
|
||
service BuckEventPublisher { | ||
rpc StreamBuckEvent(stream BuckEventRequest) returns (stream BuckEventResponse); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under both the MIT license found in the | ||
* LICENSE-MIT file in the root directory of this source tree and the Apache | ||
* License, Version 2.0 found in the LICENSE-APACHE file in the root directory | ||
* of this source tree. | ||
*/ | ||
|
||
#![feature(error_generic_member_access)] | ||
|
||
tonic::include_proto!("event_publisher"); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, to partially respond to Stiopa on this: That seems hard to practically implement on the buck2 side, since we may create a number of different instances of the client for each command. And even if we didn't do that, it seems unwise to prevent ourselves from doing that in the future