Fix recent bugs with shim/third-party #751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
dtolnay
requested changes
Aug 24, 2024
Comment on lines
1
to
9
| buildscript = [] | ||
|
|
||
| [platform_fixup.'cfg(any(target_arch = "aarch64", target_arch = "loongarch64", target_arch = "mips64", target_arch = "powerpc64", target_arch = "wasm32", target_arch = "x86_64"))'] | ||
| buildscript = [] | ||
| rustc_flags = ['--cfg=fast_arithmetic="64"'] | ||
|
|
||
| [platform_fixup.'cfg(not(any(target_arch = "aarch64", target_arch = "loongarch64", target_arch = "mips64", target_arch = "powerpc64", target_arch = "wasm32", target_arch = "x86_64")))'] | ||
| buildscript = [] | ||
| rustc_flags = ['--cfg=fast_arithmetic="32"'] |
There was a problem hiding this comment.
Please run the upstream build script, instead of transcribing the logic like this.
Example:
buck2/shim/third-party/rust/fixups/num-traits/fixups.toml
Lines 1 to 2 in 9beff40
There was a problem hiding this comment.
sgtm, I didn't realize thats what the syntax does
Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, have fixup script evaluate the build configuration. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files.
|
@dtolnay ptal |
adam-singer
force-pushed
the
adams/3rdparty-bug-fixes
branch
from
5530e07
to
08b8b3f
Compare
|
@dtolnay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Aug 24, 2024
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed builds at TraceMachina/buck2 recently broke due to inconsistencies with shim/third-party directory.
reindeer buckifywill not delete existingCargo.lockandBUCKif they already exist.reindeer updatemight assume thatreindeer buckifywas done first. A simple and consistent way is to ensure those files are deleted before callingreindeerinstead of assuming howreindeerwill behave.serde-rs recently introduced a rustc configuration flag that has to be set.
fast_arithmeticchooses the architecture based ontarget_arch, repeat the same in the fixup scripts.zstdis missing header files, most likely not caught due to staleCargo.lockandBUCKfiles.