Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fixes: yum repos; disable logind; chef 18 #254

Closed
wants to merge 1 commit into from
Closed

CI fixes: yum repos; disable logind; chef 18 #254

wants to merge 1 commit into from

Conversation

jaymzh
Copy link
Collaborator

@jaymzh jaymzh commented Feb 6, 2025 •
edited
Loading

  • centos8 mirrors have moved, adjust kitchen setup accordingly.
  • logind can't run in containers
  • modern chef
  • Newer chef requires at least debian 11 for SSL compatability
  • rsyslog needs several tweaks to run in containers, added to ci_fixes
  • default apache config in centos points to some certs, so make those

This makes everything green except for debian which requires
significant refactors of fb_apt, which can be found in #250, but I
didn't want production-effecting stuff mixed with CI fixes

Signed-off-by: Phil Dibowitz phil@ipom.com

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch 4 times, most recently from 1fc7e00 to 50a1c2e Compare February 6, 2025 22:55
@jaymzh jaymzh changed the title test Fix yum repos for kitchen tests Feb 6, 2025
@jaymzh jaymzh requested a review from dafyddcrosby February 6, 2025 22:55
dafyddcrosby
dafyddcrosby requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@dafyddcrosby dafyddcrosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the 18 branch, since that's what we've been contributing upstream with

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from 50a1c2e to 1711fd4 Compare February 6, 2025 23:55
@jaymzh jaymzh requested a review from dafyddcrosby February 6, 2025 23:55
@facebook-github-bot
Copy link
Contributor

@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@dafyddcrosby
Copy link
Contributor

Crap, I forgot that there was that Docker publishing issue with 18.5.0. https://hub.docker.com/r/chef/chef/tags?name=18.

Let's say 18.6.14 instead? https://hub.docker.com/layers/chef/chef/18.6.14/images/sha256-a303c5226a51f02108de1c3bd9cc99805de81de5d0c32455fb3aa30b9eda547f We've backported a lot of that stuff, so it's a close enough approximation for now

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from 294b653 to a18d6b7 Compare February 7, 2025 22:27
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from a18d6b7 to 2e50dfe Compare February 7, 2025 22:32
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from 2e50dfe to 88f65ac Compare February 7, 2025 22:55
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@jaymzh jaymzh changed the title Fix yum repos for kitchen tests CI fixes: yum repos; disable logind; chef 18 Feb 7, 2025
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from ee61daa to 5f3a857 Compare February 8, 2025 19:07
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from 5f3a857 to 01bfb4b Compare February 8, 2025 19:13
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from 932720d to ca57c44 Compare February 8, 2025 20:59
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from ca57c44 to 7c0a3a5 Compare February 8, 2025 21:03
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
ca03069 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
ff62c5b 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
74bb668 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
44fbbbe 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
c62c3b6 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
ba7ac85 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
59df4fc 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
a85978b 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 8, 2025
@jaymzh
Modernize testing platforms
468027d 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 13, 2025
@jaymzh
Modernize testing platforms
659fcb4 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
@facebook-github-bot
Copy link
Contributor

@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from ffc603a to cf6ea7a Compare February 13, 2025 21:40
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

@jaymzh
CI fixes: yum repos; disable logind; chef 18
1030af0 
* centos8 mirrors have moved, adjust kitchen setup accordingly.
* logind can't run in containers
* modern chef
* Newer chef requires at least debian 11 for SSL compatability
* rsyslog needs several tweaks to run in containers, added to ci_fixes

This makes everything green _except_ for debian which requires
significant refactors of fb_apt, which can be found in facebook#250, but I
didn't want production-effecting stuff mixed with CI fixes

Signed-off-by: Phil Dibowitz <phil@ipom.com>
@jaymzh jaymzh force-pushed the fix-centos-mirrors branch from cf6ea7a to 1030af0 Compare February 13, 2025 22:11
@facebook-github-bot
Copy link
Contributor

@jaymzh has updated the pull request. You must reimport the pull request before landing.

jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 13, 2025
@jaymzh
Modernize testing platforms
ef1eaac 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 13, 2025
@jaymzh
Modernize testing platforms
bd10b08 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
@facebook-github-bot
Copy link
Contributor

@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1014511.

jaymzh added a commit to jaymzh/chef-cookbooks that referenced this pull request Feb 14, 2025
@jaymzh
Modernize testing platforms
f9863d5 
Chef 18, Workstaiton 25, Centos 9&10, Debian 12, Ubuntu 22+

This also removes an old monkeypatch.

It is based on the CI Fixes PR facebook#254

Signed-off-by: Phil Dibowitz <phil@ipom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davide125 davide125 davide125 left review comments

@dafyddcrosby dafyddcrosby dafyddcrosby approved these changes

@joshuamiller01 joshuamiller01 Awaiting requested review from joshuamiller01 joshuamiller01 is a code owner

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaymzh @facebook-github-bot @dafyddcrosby @davide125