Add ability to visualize UIColor, CIColor, and CGColorRef. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if isCFColor: | ||
| return 1 | ||
| else: | ||
| return 0 |
There was a problem hiding this comment.
What's the reason for using 0/1 instead of False/True?
There was a problem hiding this comment.
Copied the pattern from elsewhere in the script. Happy to change it.
There was a problem hiding this comment.
Cone to think of it, the != 0 is already returning a boolean. We can just return that.
|
Looks good, thank you! |
|
@kastiglione updated return statements |
kastiglione
added a commit
that referenced
this pull request
Aug 10, 2015
…sualize-colors Add ability to visualize UIColor, CIColor, and CGColorRef.
|
@ZevEisenberg Thank you! If you have any other ideas, would love to get more pull requests or issues as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this:
We could add more fancy visualization, including rendering text of what the constituent colors are, like Apple does, but I figured it would be a good idea to start simple.
Fixes #103