Improve findinstances handling of Swift subclasses #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
commented
Jan 5, 2018
| export INSTALL_NAME = "" | ||
| ifneq ($(LD_DYLIB_INSTALL_NAME), "") | ||
| export INSTALL_NAME = | ||
| ifneq ($(LD_DYLIB_INSTALL_NAME),) |
There was a problem hiding this comment.
@keith does this change look legit? The original here was still adding LD_DYLIB_INSTALL_NAME=... to xcodebuild command, but this change appears to fix that.
There was a problem hiding this comment.
yea seems fine, shouldn't have had the quotes in the first place I think, my bad.
|
Super nice improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
findinstancescurrently requires the exact class name. For classes implemented in Swift, the name includes the module name, for exampleSuperKit.DuperClass. This change allowsfindinstancesto be called with simply the class name (DuperClassin the previous example).Note: This change does handle the case where more than one module contains a class by that name. For example, if two modules each define a class named
User, then runningfindinstances Userwill list instances of both classes.This pull request also includes a few other small improvements.