Skip to content

bmessage: use regex breakpoint to match category #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kastiglione merged 4 commits into from
Dec 17, 2014
Merged

bmessage: use regex breakpoint to match category #58

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b668f8
bmessage: use regex breakpoint to match category
kastiglione Dec 4, 2014
ee6c3b2
bmessage: Allow optional category
Dec 10, 2014
6e99fbb
Use verbose regex for bmessage input
Dec 10, 2014
0fbaa0c
Use exact name when category is given
Dec 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions commands/FBDebugCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,17 @@ def args(self):
def run(self, arguments, options):
expression = arguments[0]

match = re.match(r'([-+])*\[(.*) (.*)\]', expression)
methodPattern = re.compile(r"""
(?P<scope>[-+])?
\[
(?P<target>.*?)
(?P<category>\(.+\))?
\s+
(?P<selector>.*)
\]
""", re.VERBOSE)

match = methodPattern.match(expression)

if not match:
print 'Failed to parse expression. Do you even Objective-C?!'
Expand All @@ -93,9 +103,10 @@ def run(self, arguments, options):
print 'Your architecture, {}, is truly fantastic. However, I don\'t currently support it.'.format(arch)
return

methodTypeCharacter = match.group(1)
classNameOrExpression = match.group(2)
selector = match.group(3)
methodTypeCharacter = match.group('scope')
classNameOrExpression = match.group('target')
category = match.group('category')
selector = match.group('selector')

methodIsClassMethod = (methodTypeCharacter == '+')

Expand Down Expand Up @@ -135,7 +146,8 @@ def run(self, arguments, options):
return

breakpointClassName = objc.class_getName(nextClass)
breakpointFullName = '{}[{} {}]'.format(methodTypeCharacter, breakpointClassName, selector)
formattedCategory = category if category else ''
breakpointFullName = '{}[{}{} {}]'.format(methodTypeCharacter, breakpointClassName, formattedCategory, selector)

breakpointCondition = None
if targetIsClass:
Expand All @@ -145,7 +157,11 @@ def run(self, arguments, options):

print 'Setting a breakpoint at {} with condition {}'.format(breakpointFullName, breakpointCondition)

lldb.debugger.HandleCommand('breakpoint set --fullname "{}" --condition "{}"'.format(breakpointFullName, breakpointCondition))
if category:
lldb.debugger.HandleCommand('breakpoint set --fullname "{}" --condition "{}"'.format(breakpointFullName, breakpointCondition))
else:
breakpointPattern = '{}\[{}(\(.+\))? {}\]'.format(methodTypeCharacter, breakpointClassName, selector)
lldb.debugger.HandleCommand('breakpoint set --func-regex "{}" --condition "{}"'.format(breakpointPattern, breakpointCondition))

def classItselfImplementsSelector(klass, selector):
thisMethod = objc.class_getInstanceMethod(klass, selector)
Expand Down