Prevent overly eager regex match in fv command
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'll merge it. |
mattjgalloway
added a commit
that referenced
this pull request
Sep 15, 2015
Prevent overly eager regex match in `fv` command
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex used in
fvis overly eager about how it matches the class name. This change replaces a.*with\S*. Without this, a formatted object embedded in a view's description could be matched as the address of the view. For example:<ABCOneTwoThreeView: 0x25f9f180; frame = (12 606; 401 401); image = <UIImage: 0x215e9a80; …>>Previously, the
fvcommand would match the second address (0x215e9a80). This change will capture the first address in this case.