-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Issue with typescript) TypeError: Converting circular structure to JSON #11582
Labels
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
probably fixed by microsoft/TypeScript#47604 (haven't checked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If for some reason, you type props as null and return null in
render
and then use that component with children (implicitly sets this.props.children):
the resulting error crashes npm start
Did you try recovering your dependencies?
(Write your answer here.)
my-ts-app-2:
npm --version
gets8.1.1
solver:
yarn --version
gets3.0.2
Which terms did you search for in User Guide?
(Write your answer here if relevant.)
Environment
(paste the output of the command here.)
Steps to reproduce
(Write your steps here:)
npx create-react-app@next --scripts-version=@next --template=typescript@next my-ts-app
cd my-ts-app
Null.tsx
as shown above and editindex.tsx
as shown aboveExpected behavior
(Write what you thought would happen.)
Errors but doesn't crash typescript itself
Actual behavior
I don't think typescript is supposed to crash
(Write what happened. Please add screenshots!)
Before typing props as null
After
Reproducible demo
(Paste the link to an example project and exact instructions to reproduce the issue.)
icecream17/my-ts-app-2@9aa67c5
The text was updated successfully, but these errors were encountered: