-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opens Chrome stable if Chrome Canary is running #1213
Comments
created PR #1215 |
@pornel Can you help me verify by change "Google Chrome" to "Chrome" in |
Yes, changing "Google Chrome" to "Chrome" in the applescript makes Canary reload the page as expected. |
Should be fixed in |
Description
npm start
opens wrong browser. I have both Chrome and Chrome Canary on my system, but I only use Canary (which is set as my default browser system-wide).Expected behavior
npm start
should open my default browser.Actual behavior
Ignores my default browser setting, and opens Chrome (stable).
Reproducible Demo
npm start
Cause of the bug
node_modules/react-dev-utils/openBrowser.js:
grep incorrectly matches "Google Chrome Canary". Probably the same error would happen with Beta.
seems to fix the problem (tested on OS X 10.11). Alternatively,
pgrep -x "Google Chrome"
may give more precise result.The text was updated successfully, but these errors were encountered: