Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes not detected by create react app #1374

Closed
shabanraza opened this issue Jan 11, 2017 · 13 comments
Closed

Changes not detected by create react app #1374

shabanraza opened this issue Jan 11, 2017 · 13 comments

Comments

@shabanraza
Copy link

Once i started the project using npm start but doing changes in any file is not detected automatically and livereload doesn't work mostly time
How to resolve this issue

@gaearon
Copy link
Contributor

gaearon commented Jan 11, 2017

What editor are you using?

@gaearon
Copy link
Contributor

gaearon commented Jan 11, 2017

There’s some suggestions in #659.
Some common causes:

@gaearon
Copy link
Contributor

gaearon commented Jan 11, 2017

Also, do you have yarn installed? May be related to #1370 (comment).

@shabanraza
Copy link
Author

shabanraza commented Jan 12, 2017 via email

@shabanraza
Copy link
Author

Could you please suggest me which editor should i use so that it can behave properly

@gaearon
Copy link
Contributor

gaearon commented Jan 12, 2017

cc @prigara, this is a real pain point.
Does safe write absolutely have to be on by default?

@prigara
Copy link
Contributor

prigara commented Jan 12, 2017

@gaearon disabling safe write by default is not an option for us, it might affect too many users, sorry. We are going to start investigating how the webpack file watcher works and hopefully will be able to send a PR to improve it on Window. Should help not only IJ users, but also vim users suffering from the same issue.
Any chance you know the main issue for that on the Webpack tracker?
Upd: I guess it should be in this project: https://github.com/webpack/watchpack

@gaearon
Copy link
Contributor

gaearon commented Jan 12, 2017

I agree it would be a better solution. Yes, it’s watchpack. AFAIK it uses https://github.com/paulmillr/chokidar under the hood which in turn uses fsevents on OS X, and polling (I think) on other platforms.

@gaearon
Copy link
Contributor

gaearon commented Jan 12, 2017

cc @TheLarkInn might provide details / support for prioritizing this on WP side

@prigara
Copy link
Contributor

prigara commented Jan 17, 2017

@gaearon, I have some good news. After some investigations @alexander-doroshko found a PR that fixes the issue. It has landed in Webpack 2.2, we tested it on Windows and all works like a charm. And it should work both with chokidar and sane.

@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2017

You folks are amazing 💜👯😇

@prigara
Copy link
Contributor

prigara commented Jan 17, 2017

@gaearon are you planning to move to webpack 2 soon?

@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2017

Within a month of its stable release.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants