Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directory removal #1672

Closed
Timer opened this issue Feb 27, 2017 · 3 comments · Fixed by #2397
Closed

Fix directory removal #1672

Timer opened this issue Feb 27, 2017 · 3 comments · Fixed by #2397

Comments

@Timer
Copy link
Contributor

Timer commented Feb 27, 2017

As part of our kitchensink test, we nohup a few node processes that need to be cleaned up on script exit.

We need to figure out why this doesn't work: https://github.com/facebookincubator/create-react-app/blob/master/tasks/e2e-kitchensink.sh#L24

@Timer Timer changed the title e2e-kitchensink leaves nohup'ed processes running Fix directory removal Feb 28, 2017
@chitchu
Copy link
Contributor

chitchu commented Mar 1, 2017

Looked up the manual for kill and the -s switch requires a signal_name and not a signal_number. I reckon the line should be:

ps -ef | grep 'react-scripts' | grep -v grep | awk '{print $2}' | xargs kill -s KILL

@Timer
Copy link
Contributor Author

Timer commented Mar 7, 2017

@chitchu I believe that's the case for unix (travis), I'm not sure about appveyor though. Could you submit a PR changing this behavior and we can see what happens? 😄

@chitchu
Copy link
Contributor

chitchu commented Mar 8, 2017

The message Device or resource busy still pops up. I'll have a deeper look into this. But if anyone with more experience in windows land can chime in that'd be great.

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants