-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint - no-unused-expressions warning for template tags #2647
Comments
Overriding our ESLint settings is not really supported. It technically "works" for IDEs so we documented it, but we still want everyone to have the same base configuration. This helps make sure it works correctly for everyone, that bugfixes are coordinated, and that everyone has mostly good experience out of the box. In this particular case it seems like we should change our config. Our stance is that we try to create a config that's good for most users rather than allow users to make individual tweaks, thus keeping the base config less ideal. If you send a PR for fixing this in our config I'm happy to take that in. |
This issue can be closed now 👍 |
Thanks! |
This feature has been released as of v1.0.11. :) |
I'm using
styled-components
'injectGlobal
template tag function, like so:And I got warnings about
injectGlobal
being an unused expression. So I've modified my.eslintrc
to be the following:This seems to stop ESLint warnings in Nuclide, but I'm still getting them in the browser console and shell:
Am I configuring something wrong?
The text was updated successfully, but these errors were encountered: