Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ejecting adds all packages to dependencies #3062

Closed
tbillington opened this issue Sep 4, 2017 · 3 comments
Closed

Ejecting adds all packages to dependencies #3062

tbillington opened this issue Sep 4, 2017 · 3 comments

Comments

@tbillington
Copy link

tbillington commented Sep 4, 2017

Not a bug report, just curious why all packages are put under dependencies in package.json and none under devDependencies when ejecting with react-scripts 1.0.13. Surely things like webpack, chalk, and eslint are not runtime dependencies? I can't see it explained anywhere and I know that previously most of the packages would go under devDependencies as I am using an ejected version of an old create-react-app.

@miraage
Copy link

miraage commented Sep 4, 2017

It was removed in 1.0.8 (#2657).
It looks easy to fix on the paper.
Welcome, dependencies.
I think they should be added as devDependencies except promise, whatwg-fetch, object-assign which are used by polyfills.js as an additional entry.

@gaearon
Copy link
Contributor

gaearon commented Sep 4, 2017

Please see #2696.

There is no real difference in our case.
Feel free to move them if you have opinions about them.

@gaearon gaearon closed this as completed Sep 4, 2017
@tbillington
Copy link
Author

Ok, I can see why, thanks for the info :)

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants