-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap's sass is not working with new r2.0.0-next.66cc7a90 (with opt-in sass) #4363
Comments
Same here. |
I'm getting the same error. Deleting Thanks for supporting sass and looking forward to a solution! |
I think this is related to webpack-contrib/sass-loader#556 For me it happenend when I had a npm package with the same name as a sass file I was trying to import from node_modules. |
AFAIK sass-loader@7.0.1 solves this problem. |
Does someone want to submit a PR to update |
Just tested cra@2-beta + eject + sass-loader@7.0.1 |
Before we close this, worth keeping an eye on webpack-contrib/sass-loader#556 (comment). |
I merged the PR updating |
Could the fixed alpha version be deployed to npm? |
add ``import 'bootstrap/dist/js/bootstrap.bundle.min'; to your route index.js |
This is working in v2 beta. We don't use the options linked in above issue -- not sure this is worth keeping open unless someone can formulate a better proposal on what we need to keep an eye out for or do. |
* Update sass-loader (facebook#4363) * Added bootstrap scss test (facebook#4376)
Is this a bug report?
Doubt it, but it might be interesting to know, due to the fact that bootstrap is recommended in the README, and bootstrap itself recommends using sass for its full potential
Relates to #3815
Environment
node -v
: 8.9.1yarn --version
(if you use Yarn): 1.6.0npm ls react-scripts
(if you haven’t ejected): r2.0.0-next.66cc7a90debian sid amd64
Steps to Reproduce
npx create-react-app myapp --scripts-version react-scripts@2.0.0-next.66cc7a90
index.css
toindex.scss
index.js
to point toindex.scss
yarn add bootstrap
index.scss
and add at the bottom@import "~bootstrap/scss/bootstrap.scss";
yarn && yarn start
Expected Behavior
No error is shown.
Actual Behavior
This error appears:
More info
According to bootstrap:
I think those loaders are missing, does anyone know if there's an easy way to add them without ejecting?
I hope to be helpful,
Thanks to everyone!
The text was updated successfully, but these errors were encountered: