-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File loader issue with duplicate filenames in dev mode #445
Milestone
Comments
arunoda
added a commit
to arunoda/create-react-app
that referenced
this issue
Aug 15, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: facebook#445
gaearon
pushed a commit
that referenced
this issue
Aug 15, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: #445
gaearon
pushed a commit
that referenced
this issue
Aug 22, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: #445
stayradiated
pushed a commit
to stayradiated/create-react-app
that referenced
this issue
Sep 7, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: facebook#445
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this issue
Oct 25, 2016
This will work correctly when there are duplicate filenames in different paths. Fixes: facebook#445
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This happens when there's a media file with the same file name but in different directories. Here's a sample app: https://github.com/arunoda/file-loader-cra-issue
Here's the related code:
As you see both pngs has the same name. Now in the dev mode, it tries to load the first file in all the case.
We could easily fix this by hashing the filename in dev mode too.
I came across this while playing with React Storybook.
The text was updated successfully, but these errors were encountered: