Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size reporter on Windows #4927

Closed
fiddep opened this issue Aug 27, 2018 · 1 comment
Closed

File size reporter on Windows #4927

fiddep opened this issue Aug 27, 2018 · 1 comment

Comments

@fiddep
Copy link
Contributor

fiddep commented Aug 27, 2018

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

windows, build, size

Environment

Environment:
  OS:  Windows 10
  Node:  10.9.0
  Yarn:  1.9.4
  npm:  6.2.0
  Watchman:  Not Found
  Xcode:  N/A
  Android Studio:  Not Found

Packages: (wanted => installed)
  react: ^16.4.2 => 16.4.2
  react-dom: ^16.4.2 => 16.4.2
  react-scripts: 1.1.5 => 1.1.5

Steps to Reproduce

  1. create a fresh app
  2. run yarn build
  3. add stuff to any file
  4. run yarn build

Expected Behavior

the output would show that the file size has increased if a previous build was present

Actual Behavior

Nothing else except the current filesize is show
Before: http://prntscr.com/kndf9p
After: http://prntscr.com/kndit2

Possible Solution

The issue seems to be related to Windows and its path delimiter.
Adding
.replace(/\\/g, '/')
in FileSizeReporter
Solves the problem and don't seem to cause any issues on other OS

Would happily submit a PR for this

@Timer
Copy link
Contributor

Timer commented Sep 17, 2018

Please send a PR! Thanks. 😄

@Timer Timer closed this as completed Sep 23, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants