Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GitHub hosting instructions #501

Closed
mohsen1 opened this issue Aug 26, 2016 · 5 comments · Fixed by #841
Closed

Change GitHub hosting instructions #501

mohsen1 opened this issue Aug 26, 2016 · 5 comments · Fixed by #841

Comments

@mohsen1
Copy link

mohsen1 commented Aug 26, 2016

I need this specifically for the new GitHub pages /docs feature. I want my output folder to be /docs not /build.

@andyeskridge
Copy link

andyeskridge commented Aug 26, 2016

You could just modify the build command to move from /build to /docs.

Something like:

"scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build && rm -r docs/ && mv build/ docs/",
    "eject": "react-scripts eject"
  }

EDIT: One thing you will need to worry about is clearing out your docs folder before moving files over. So you might want to add a rm -r docs/ before the mv

@gaearon gaearon added this to the 0.3.0 milestone Aug 27, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 27, 2016

I don't plan to change the build folder name.
I agree that this is out of scope and you should use filesystem commands for that.

However I do think that we should update GH deploy instructions to show how to do this.
Would you like to send a PR for that? You would need to change template/README.md and scripts/build.js.

@andyeskridge
Copy link

I can send in a PR for this.

@gaearon
Copy link
Contributor

gaearon commented Sep 2, 2016

I’ll close, let’s track #520 instead.

@gaearon gaearon closed this as completed Sep 2, 2016
@gaearon gaearon reopened this Sep 17, 2016
@gaearon gaearon changed the title Configurable build folder name Change GitHub hosting instructions Sep 17, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 17, 2016

As described in #520 (comment), let’s find (or create) a CLI package that just publishes a directory to GH pages assuming /docs configuration.

@gaearon gaearon added this to the 1.0.0 milestone Sep 17, 2016
@fson fson closed this as completed in #841 Oct 4, 2016
@gaearon gaearon modified the milestones: 0.7.0, 1.0.0 Oct 4, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants