Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-scripts readme "npm run build fails to minify" section after v2 #5104

Closed
sag1v opened this issue Sep 26, 2018 · 1 comment
Closed

react-scripts readme "npm run build fails to minify" section after v2 #5104

sag1v opened this issue Sep 26, 2018 · 1 comment

Comments

@sag1v
Copy link
Contributor

sag1v commented Sep 26, 2018

Is this a bug report?

No

Now that v2 compiles node_modues this section in readme should be updated.

@gaearon suggested to write "migrate to 2.x" .

Should we keep the current text as well (for legacy users)?
What about a link to a guide for migrating?
@sag1v sag1v mentioned this issue Sep 26, 2018
Merged
@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

closing in favor of PR

@Timer Timer closed this as completed Sep 26, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Timer @sag1v