Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as per #5104 #5105

Merged
merged 3 commits into from
Sep 26, 2018
Merged

as per #5104 #5105

merged 3 commits into from
Sep 26, 2018

Conversation

sag1v
Copy link
Contributor

@sag1v sag1v commented Sep 26, 2018

Update npm run build fails to minify section.

as per #5104

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

Hmm, how about the following:

Starting in Create React App v2, we now compile all ES.Next features found in node_modules.
This means you can consume packages and not worry about them being syntax-incompatible with any browser.
If you're seeing this error, you're likely using an old version of react-scripts and need to upgrade to react-scripts@>=2.0.0.

@sag1v
Copy link
Contributor Author

sag1v commented Sep 26, 2018

@Timer I like this because it covers 3.x and above versions as well 😆

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sag1v
Copy link
Contributor Author

sag1v commented Sep 26, 2018

@Timer Is there a migration guide somewhere?
I think it's a good place to link it, but couldn't find one.

@Timer
Copy link
Contributor

Timer commented Sep 26, 2018 •
edited
Loading

No need for one. We explain how to migrate at the top of the README.

... and it doesn't exist yet

@sag1v
Copy link
Contributor Author

sag1v commented Sep 26, 2018 •
edited
Loading

So maybe an internal link to top section?

... eg:
Updating to New Releases

@Timer Timer merged commit cbf5320 into facebook:master Sep 26, 2018
@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

This is good enough for now, thanks!

@Timer Timer added this to the 2.0.0 milestone Sep 26, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@sag1v @Timer
Update minify instructions (facebook#5105)
04a5c34 
* changed to Migrate to v2.x

* richer explanation

* Update README.md
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sag1v @facebook-github-bot @Timer