Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html-webpack-plugin dependency #6107

Closed
aftabnack1 opened this issue Dec 31, 2018 · 5 comments
Closed

Update html-webpack-plugin dependency #6107

aftabnack1 opened this issue Dec 31, 2018 · 5 comments
Assignees
Labels

Comments

@aftabnack1
Copy link

I have fixed an issue that I found with html-webpack-plugin jantimon/html-webpack-plugin#1072
And I have noticed my change is present in the latest next release of html-webpack-plugin.

So can we please update the package version for react-scripts to html-webpack-plugin@4.0.0-beta.5 from current alpha.2?

@mrmckeb
Copy link
Contributor

mrmckeb commented Jan 4, 2019

Hi @aftabnack1, that sounds like a good fix. Would you like to create a PR? If not, I could look at it this weekend.

@mrmckeb mrmckeb self-assigned this Jan 4, 2019
@aftabnack1
Copy link
Author

@mrmckeb please go ahead and take care of this. Thanks!

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@Aftabnack
Copy link
Contributor

Aftabnack commented Feb 8, 2019

Added a PR for the same! Can someone review and merge the PR?

@stale stale bot removed the stale label Feb 8, 2019
@stale
Copy link

stale bot commented Mar 10, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 10, 2019
@iansu iansu closed this as completed Mar 10, 2019
@lock lock bot locked and limited conversation to collaborators Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants