-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Workbox to 4.1.0 #6659
Comments
There are a number of issues with the service worker from the older version of the plugin. I ejected create-react-app and updated the version number in the package.json to 4.1.1 (latest version of workbox-webpack-plugin). Most of these issues have now been resolved in the new version, and nothing else is required apart from updating the version number of the npm module. This should be a relatively simple update. |
@r0ughnex would you like to submit a PR? |
@iansu: Sure, I'll take this one up. |
Currently the generated service worker workbox version is:
importScripts("https://storage.googleapis.com/workbox-cdn/releases/3.6.3/workbox-sw.js")
The latest is 4.1: see https://github.com/GoogleChrome/workbox/releases
The import can now read as:
importScripts("https://storage.googleapis.com/workbox-cdn/releases/4.1.0/workbox-sw.js")
This update improves a number of things, including adding the much needed skipWaiting() message handler:
GoogleChrome/workbox#1929
The text was updated successfully, but these errors were encountered: